Update vof examples #1390

AmishgaAlphonius · 2024-11-28T00:02:42Z

Description

Updates the following example before Lethe 1.0 release:

Dam-break
Rayleigh-Taylor instability
Capillary wave
Air bubble compression
Sloshing in a rectangular tank

Additionally, this PR reverts the squared term in the VOF DCDD stabilization correctional direction vector (#1103) to the power 1.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Lethe documentation is up to date
Copyright headers are present and up to date
The branch is rebased onto master
Code is indented with indent-all and .prm files (examples and tests) with prm-indent
Links are added to parent .rst files
The example is following the standard format

Pull request related list:

Labels are applied
There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
If any future works is planned, an issue is opened
The PR description is cleaned and ready for merge

AmishgaAlphonius · 2024-11-28T03:30:27Z

I forgot to update the tests after the revert of the dcdd term. I will do so tomorrow morning!

hepap

Good job with these updates and finding the bug :)

hepap · 2024-11-28T13:49:16Z

applications_tests/lethe-fluid/gls_droplet_marangoni_effect.output

+Enstrophy: 97.103
+Kinetic energy: 0.001011

 *******************************************************************************
-Transient iteration: 3        Time: 0.003    Time step: 0.001    CFL: 0.17532 
+Transient iteration: 3        Time: 0.003    Time step: 0.001    CFL: 0.17531
 *******************************************************************************
-Enstrophy  : 299.29
-Kinetic energy : 0.0039173
+Enstrophy: 299.47
+Kinetic energy: 0.0039228

 *******************************************************************************
-Transient iteration: 4        Time: 0.004    Time step: 0.001    CFL: 0.30998 
+Transient iteration: 4        Time: 0.004    Time step: 0.001    CFL: 0.31002
 *******************************************************************************
-Enstrophy  : 513.69
-Kinetic energy : 0.0079426
+Enstrophy: 513.9
+Kinetic energy: 0.0079503

 *******************************************************************************
-Transient iteration: 5        Time: 0.005    Time step: 0.001    CFL: 0.40316 
+Transient iteration: 5        Time: 0.005    Time step: 0.001    CFL: 0.40314
 *******************************************************************************
-Enstrophy  : 705.36
-Kinetic energy : 0.012344
+Enstrophy: 705.51
+Kinetic energy: 0.012354


I checked, and it went back to the same values as before the square DCDD

hepap · 2024-11-28T13:52:03Z

applications_tests/lethe-fluid/gls_vof_1_isothermal_compressible_fluid.output

@@ -28,4 +28,4 @@ Transient iteration: 2        Time: 0.2      Time step: 0.1      CFL: 1.64181
 VOF Mass Conservation
 ----------------------
    time     surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold 
-2.000000e-01    6.579242e-01            7.895070e-01      -2.229965e-02       4.765510e-02    3.420758e-01            3.420758e+02       1.863059e+01      -4.003717e+01         5.000000e-01 
+2.000000e-01    6.579141e-01            7.894950e-01      -2.231310e-02       4.763344e-02    3.420859e-01            3.420859e+02       1.864223e+01      -4.002050e+01         5.000000e-01


but not this one :o

Thanks for taking the time to check them! :)
The values changed a bit with the fix on the pressure interpolation on faces (#1234) and we can see that the values remain somewhat similar to the ones that are overwritten.

CHANGELOG.md

hepap · 2024-11-28T14:50:26Z

doc/source/examples/multiphysics/dam-break/images/dam-break-initial-configuration.svg

You better leave the white background for dark mode

Thanks, I forgot to reveal it before exporting!

hepap · 2024-11-28T14:51:08Z

doc/source/examples/multiphysics/dam-break/images/refinement.png

Looks clean with the new colors

doc/source/examples/multiphysics/rayleigh-taylor-instability/images/adaptive_mass.png

doc/source/examples/multiphysics/rayleigh-taylor-instability/images/constant_mass.png

hepap · 2024-11-28T15:08:52Z

applications_tests/lethe-fluid/gls_vof_2_isothermal_compressible_fluids.output

@@ -28,4 +28,4 @@ Transient iteration: 2        Time: 0.2      Time step: 0.1      CFL: 1.53178
 VOF Mass Conservation
 ----------------------
    time     surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold 
-2.000000e-01    6.579652e-01            7.895557e-01      -2.004270e-02       4.448404e-02    3.420348e-01            1.710176e+01       8.361416e-01      -1.863500e+00         5.000000e-01 
+2.000000e-01    6.579587e-01            7.895478e-01      -2.005946e-02       4.446851e-02    3.420413e-01            1.710209e+01       8.365478e-01      -1.862997e+00         5.000000e-01


nor this one! The rest of the application tests returned to their previous values (before the square)

same here :)

blaisb

Some comments to address

blaisb · 2024-11-28T21:38:37Z

doc/source/examples/multiphysics/sloshing-in-rectangular-tank/sloshing-in-rectangular-tank.rst


 --------
 Features
 --------

 - Solver: ``lethe-fluid`` 
 - Volume of fluid (VOF)
- Unsteady problem handled by an adaptive BDF2 time-stepping scheme 
+- Unsteady problem handled by an adaptive BDF2 time stepping scheme


Suggested change

- Unsteady problem handled by an adaptive BDF2 time stepping scheme

- Unsteady problem handled by an adaptive BDF2 time-stepping scheme

time-stepping is a compound noun and takes an hyphen in this case. I am pretty sure of that.

blaisb · 2024-11-28T21:39:33Z

doc/source/examples/multiphysics/sloshing-in-rectangular-tank/sloshing-in-rectangular-tank.rst


 -----------------------
 Description of the Case
 -----------------------

-Predicting the dynamics of free surface waves is essential for many industrial applications (e.g. transport of liquified natural gas).
+Predicting the dynamics of free surface waves is essential for many industrial applications (e.g. transport of liquefied natural gas).


FYI both spelling are acceptable.
https://books.google.com/ngrams/graph?content=liquefy%2Cliquify&year_start=1800&year_end=2008&corpus=15&smoothing=3

blaisb · 2024-11-28T21:40:52Z

doc/source/examples/multiphysics/sloshing-in-rectangular-tank/sloshing-in-rectangular-tank.rst

@@ -64,7 +68,7 @@ Parameter File
 Simulation Control
 ~~~~~~~~~~~~~~~~~~

-The results for this problem are highly sensitive to the accuracy of the time-stepping scheme. For this reason, we use a 2nd order backward differentiation scheme (``bdf2``) with a variable time step. The ``adaptive time step scaling`` is set to :math:`1.025` to ensure that the time-step does not rise too quickly during wave oscillations.
+The results for this problem are highly sensitive to the accuracy of the time stepping scheme. For this reason, we use a 2nd order backward differentiation scheme (``bdf2``) with a variable time step. The ``adaptive time step scaling`` is set to :math:`1.025` to ensure that the time step does not rise too quickly during wave oscillations.


Suggested change

The results for this problem are highly sensitive to the accuracy of the time stepping scheme. For this reason, we use a 2nd order backward differentiation scheme (``bdf2``) with a variable time step. The ``adaptive time step scaling`` is set to :math:`1.025` to ensure that the time step does not rise too quickly during wave oscillations.

The results for this problem are highly sensitive to the accuracy of the time-stepping scheme. For this reason, we use a 2nd order backward differentiation scheme (``bdf2``) with a variable time step. The ``adaptive time step scaling`` is set to :math:`1.025` to ensure that the time-step does not rise too quickly during wave oscillations.

The correct form is "time-step" (with a hyphen) when used as a noun. The hyphen is used here to combine "time" and "step" into a single, unified term. Without the hyphen (as in "time step"), it might be unclear whether you're referring to the concept of a step in time or two separate ideas (a "time" and a "step").

I've changed them!

blaisb · 2024-11-28T21:41:40Z

doc/source/examples/multiphysics/sloshing-in-rectangular-tank/sloshing-in-rectangular-tank.rst


 -------
 Results
 -------

-We compare the relative height of the free surface at :math:`x=0` with an analytical solution proposed by Wu *et al.* [#wu2001]_ For the Reynolds number of :math:`2`, :math:`20` and :math:`200`, data were directly extracted from Carrica *et al.* [#carrica2007]_, whereas for the Reynolds of :math:`2000`, the simplified analytical expression of Wu *et al.* [#wu2001]_ is used. The results for Reynolds number of :math:`2`, :math:`20`, :math:`200` and :math:`2000` can be post-processed by invoking the following command from the folder of the Reynolds number of interest (:math:`Re=20` in the example below):
+We compare the relative height of the free surface at :math:`x=0` with an analytical solution proposed by Wu *et al.* [#wu2001]_ For the Reynolds number of :math:`2`, :math:`20` and :math:`200`, data were directly extracted from Carrica *et al.* [#carrica2007]_, whereas for the Reynolds of :math:`2000`, the simplified analytical expression of Wu *et al.* [#wu2001]_ is used. The results for Reynolds number of :math:`2`, :math:`20`, :math:`200` and :math:`2000` can be postprocessed by invoking the following command from the folder of the Reynolds number of interest (:math:`Re=20` in the example below):


Both spelling are acceptable. I am more a fan of the hyphen version, but anyway
https://english.stackexchange.com/questions/452969/pre-processing-post-processing-hyphen-presence-in-research-publications-writ

AmishgaAlphonius added 14 commits November 27, 2024 18:53

Add copy button

cf006c1

Update 2d dam break

3ce3297

Update refinement image

0b6602b

Update configuration figure

f1697a6

Update postprocessing file

8100126

Update parameters files

10d1264

Remove DCDD in air-bubble-compression

49b2bd8

Remove square in dcdd term

5f83a5e

Update air bubble compression example

aa542d6

Update rayleigh-taylor example

8b816a2

Update capillary wave example parameter files

82db129

Update rayleigh-taylor example

c056be6

Update examples

1808bee

Update capillary wave example

fee2a46

AmishgaAlphonius added Quick fix Ready for review Example Next release PR that would need to be merged before the next release labels Nov 28, 2024

AmishgaAlphonius self-assigned this Nov 28, 2024

Update change log

22aef30

AmishgaAlphonius requested review from blaisb and hepap November 28, 2024 00:05

AmishgaAlphonius added WIP When a PR is open but not ready for review and removed Ready for review labels Nov 28, 2024

AmishgaAlphonius added 2 commits November 27, 2024 22:59

Update sloshing example

6cabc1a

Update application tests

6bc142a

AmishgaAlphonius added Ready for review and removed WIP When a PR is open but not ready for review labels Nov 28, 2024

hepap approved these changes Nov 28, 2024

View reviewed changes

Apply suggestions from review

f3fdd1e

blaisb approved these changes Nov 28, 2024

View reviewed changes

correct time-step typos

b501c8f

AmishgaAlphonius added Reviewed and ready to merge Rebased and removed Ready for review labels Nov 29, 2024

blaisb merged commit cf20bfd into master Nov 29, 2024
11 checks passed

blaisb deleted the update-vof-examples branch November 29, 2024 11:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update vof examples #1390

Update vof examples #1390

AmishgaAlphonius commented Nov 28, 2024 •

edited

Loading

AmishgaAlphonius commented Nov 28, 2024

hepap left a comment

hepap Nov 28, 2024

hepap Nov 28, 2024

AmishgaAlphonius Nov 28, 2024

hepap Nov 28, 2024

AmishgaAlphonius Nov 28, 2024

hepap Nov 28, 2024

hepap Nov 28, 2024

AmishgaAlphonius Nov 28, 2024

blaisb left a comment

blaisb Nov 28, 2024

blaisb Nov 28, 2024

blaisb Nov 28, 2024

AmishgaAlphonius Nov 29, 2024

blaisb Nov 28, 2024

	- Unsteady problem handled by an adaptive BDF2 time stepping scheme
	- Unsteady problem handled by an adaptive BDF2 time-stepping scheme

	The results for this problem are highly sensitive to the accuracy of the time stepping scheme. For this reason, we use a 2nd order backward differentiation scheme (``bdf2``) with a variable time step. The ``adaptive time step scaling`` is set to :math:`1.025` to ensure that the time step does not rise too quickly during wave oscillations.
	The results for this problem are highly sensitive to the accuracy of the time-stepping scheme. For this reason, we use a 2nd order backward differentiation scheme (``bdf2``) with a variable time step. The ``adaptive time step scaling`` is set to :math:`1.025` to ensure that the time-step does not rise too quickly during wave oscillations.

Update vof examples #1390

Update vof examples #1390

Conversation

AmishgaAlphonius commented Nov 28, 2024 • edited Loading

Description

Checklist (will be removed when merged)

AmishgaAlphonius commented Nov 28, 2024

hepap left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blaisb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmishgaAlphonius commented Nov 28, 2024 •

edited

Loading